Code review comment for ~bryce/ubuntu/+source/fetchmail:fix-2035-hirsute

Revision history for this message
Bryce Harrington (bryce) wrote :

Thank you for the review feedback!

I've noted your two suggestions, to add set -x and the issue with the make check. Both quite sensible review feedback, but both are causing some weird stuff I don't quite understand.

Easier piece first. The weirdness is that 'make check' works fine for me. But, the solution almost certainly is to run ./configure first. This causes no issue on my end so I've added it and pushed to this MP. Please re-test and verify it works for you. I'm fine with pushing this, but kinda would like to understand why it's needed.

Harder piece is that adding 'set -x' should be a completely cosmetic change, yet it results in autopkgtest failing for me with it set. I've pushed the changes with this set, and would appreciate if you would run the tests and see if it also fails for you, and then if it does, if you have ideas what's causing it? If you're not sure, I'd like to propose chalking it up to some sort of bash bug, punt, and omit 'set -x' for now?

« Back to merge proposal