Code review comment for ~bryce/ubuntu/+source/fetchmail:fix-2035-hirsute

Revision history for this message
Lucas Kanashiro (lucaskanashiro) wrote :

The new test you added to call "make check" is not working for me locally:

autopkgtest [15:36:23]: test command1: make check
autopkgtest [15:36:23]: test command1: [-----------------------
make: *** No rule to make target 'check'. Stop.
autopkgtest [15:36:24]: test command1: -----------------------]
autopkgtest [15:36:24]: test command1: - - - - - - - - - - results - - - - - - - - - -
command1 FAIL non-zero exit status 2

The "operation" test and the others are working fine:

autopkgtest [15:39:20]: @@@@@@@@@@@@@@@@@@@@ summary
command1 FAIL non-zero exit status 2
installation PASS
service PASS
operation PASS

I am not a Python expert but the code looks good. Good job! The only thing I might add is that I'd use also "set -x" in the shell script to print the commands being executed, they can be handy when debugging failures.

Moreover, I'd strongly recommend to forward the "operation" test to Debian.

review: Needs Fixing

« Back to merge proposal