Code review comment for ~bryce/ubuntu/+source/clamav:merge-v1.0.5adfsg-1.1-noble

Revision history for this message
Andreas Hasenack (ahasenack) wrote :

I think you should have kept the po changes in the logical tag, and dropped them later on when applying on top of debian/new.

Logical should show what the delta is at that version, and it does have the po changes (which I also think were added by mistake). But they should be dropped at rebase on top of new/debian time, not in logical.

I would add a "[previously undocumented]" line to the commit that you split out about the pos, and then drop it when rebasing on new/debian, possibly with a comment ("* Dropped: previously added PO update, apparently by mistake"). You could also ping Marc to see if he remember what that was about.

review: Needs Fixing

« Back to merge proposal