Ubuntu Docker Images

Code review comment for ~bryce/ubuntu-docker-images/+git/bind9:initial-implementation

  1. Git
  2. lp:~bryce/ubuntu-docker-images/+git/bind9
  3. initial-implementation
  4. Merge into main
Revision history for this message
Sergio Durigan Junior (sergiodj) wrote :

Thanks, Bryce.

Re. the copyright holder, I think that's the right thing to do but IANAL. I'll talk to Valentin, because some of our other images have the same problem. Meanwhile, could you please remove the LICENSE file from the commit? I'm not even sure if we want to license this work using BSD-3-Clause or if we'll use another license...

As for the other changes, they look good now modulo a few nits. I wasn't able to build the Impish version of the image, but I did build the Hirsute one and it looks fine. Looking forward to running the unit tests for it.

+1, LGTM.

review: Approve

« Back to merge proposal