Code review comment for lp:~bryce/quickly/template_tests

Revision history for this message
Michael Terry (mterry) wrote :

It'd be nice to have 'run-tests' exit with a non-zero value if any test failed for ease of integration into an automated test run.

And do you know if python-distutils (or -extra) has support for finding and running a test suite? Would be good to make this suite match distutils' expectations.

Also... Maybe a good first test would be to call pylint on the project? There's an example of good pylint arguments in my branch that adds a pylint test to quickly itself: https://code.launchpad.net/~mterry/quickly/pylint/+merge/42501

review: Needs Fixing

« Back to merge proposal