Merge ppa-dev-tools:testbed-setup-failures-are-bad into ppa-dev-tools:main
Proposed by
Bryce Harrington
Status: | Merged |
---|---|
Merged at revision: | 074f622aa5bbb855dc21081010f599a08338f940 |
Proposed branch: | ppa-dev-tools:testbed-setup-failures-are-bad |
Merge into: | ppa-dev-tools:main |
Diff against target: |
122 lines (+30/-14) 3 files modified
ppa/result.py (+4/-4) scripts/ppa (+0/-1) tests/test_result.py (+26/-9) |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Athos Ribeiro (community) | Approve | ||
Canonical Server Reporter | Pending | ||
PpaDevTools Developers | Pending | ||
Review via email: mp+466028@code.launchpad.net |
Description of the change
If there is an error setting up the testbed, it'll error out before any subtests are generated. ppa-dev-tools was not correctly checking for or handling this state and required a few different fixups.
Thanks Mitchell for finding and reporting this corner case.
(Hmm, come to think of it I should probably also write test cases to accompany this...)
To post a comment you must log in.
Huh I don't see this branch fixing my issue for some reason. Am I installing it wrong?
1. I checked out testbed- setup-failures- are-bad tools_v0. 5.0+git43. 0c5c395_ amd64.snap --dangerous`
2. `snapcraft`
3. `snap install ppa-dev-
It just looks identical to the failure in the bug