Code review comment for ppa-dev-tools:job-class
Revision history for this message
| Bryce Harrington (bryce) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
7020100
(Get the code!)
> Nice work, Bryce :)
>
> I left a couple inline comments, but this LGTM as is.
Thanks!
> I am also wondering if instead of including the complete samples of the json
> files, including hand-crafted minimal samples of those would be enough. The
> reason for the question is that this change alone increased the project root
> size from <200kb to 1.9Mb (not counting git data here). While this shouldn't
> matter much ATM, I was wondering if there's any chance this could pile up in
> the future with new test additions.
Good point. Ironically I had started with hand-crafted snippets but switched to snapshots as being easier to add and more closely representative of actual usage. However, it may be better to just go ahead and add the code to download live data, and keep the local data snapshots trimmed to specific examples. You're right that over time this could pile up.