Code review comment for ppa-dev-tools:job-class

Revision history for this message
Athos Ribeiro (athos-ribeiro) wrote :

Nice work, Bryce :)

I left a couple inline comments, but this LGTM as is.

I am also wondering if instead of including the complete samples of the json files, including hand-crafted minimal samples of those would be enough. The reason for the question is that this change alone increased the project root size from <200kb to 1.9Mb (not counting git data here). While this shouldn't matter much ATM, I was wondering if there's any chance this could pile up in the future with new test additions.

review: Approve

« Back to merge proposal