Code review comment for lp:~bryce/launchpad/lp-617695-linkui

Revision history for this message
Tim Penhey (thumper) wrote :

Why assume ubuntu as the distributions? Do we need to define the distribution at all? Surely the sourcepackagename itself is enough?

Also as a general rule, we should be doing as little as possible in the view code, so the code to link the component to the sourcepackage should really go in the bugtracker code. Warning bells went off when you overloaded updateContextFromData.

review: Needs Information

« Back to merge proposal