Code review comment for lp:~bryce/launchpad/lp-586150-whiteboard-widening

Revision history for this message
Curtis Hovey (sinzui) wrote :

> === modified file 'lib/canonical/launchpad/icing/style-3-0.css.in'
> --- lib/canonical/launchpad/icing/style-3-0.css.in 2010-05-17 10:56:27 +0000
> +++ lib/canonical/launchpad/icing/style-3-0.css.in 2010-05-28 03:48:33 +0000
> @@ -409,6 +409,10 @@
> /* Keep the abilty to hide list entries. */
> display: none;
> }
> +div.widetext p {
> + max-width: 60em;
> + margin-bottom: 1.0em;
> + }

This is a very narrow definition makes this an exception for the blueprint
white board. It cannot will not be resued. If we really want an exception for
*just* the blueprint whiteboard, this then belongs in the page's
head-epilogue slot.

This rule needs to accommodate the kinds of markup and circumstances that
happen in many places in Launchpad to be included in the global CSS. I think
we need this rule, so the selector must be generalised.

I think .wide will suffice since we have a .narrow. I should be permitted to
use this with a table or a form. lists that should be the same width as the
paragraphs they are with so div and p are too specific

/me looks at other wide cases.
    table#package-requests {
        width: 60em;
        margin: 1em 0;
        }

Score! Well we have found a common rule that blueprints and soyuz can used

I think the rule should be:
.wide {
    max-width: 60em;
    margin: 1em 0;
    }

Update your file and lib/lp/soyuz/templates/archive-macros.pt
    <table id="package-requests" class="wide listing"

And we can remove one more dead rule from style.css.

review: Approve (code ui)

« Back to merge proposal