Code review comment for lp:~bryce/apport/omit_empty

Revision history for this message
Martin Pitt (pitti) wrote :

Thanks for the typo fixes!

As for the attach_root_command_outputs() fix, I feel that it would make more sense to just always skip empty keys. Also, I think we should always strip() the result, leading and trailing empty lines have little information (I'm not aware of apport hooks that attach brainfuck source :) ).

So WDYT about this:

   buf = f.read.strip()
   if not buf:
       continue

?

review: Needs Information

« Back to merge proposal