Code review comment for lp:~bryanfritt/compiz/compiz-decorator_script-edit_1192376

Revision history for this message
BryanFRitt (bryanfritt) wrote :

> You need to update the distro patch:
>
> sudo apt-get install quilt;
> export QUILT_PATCHES=debian/patches
> quilt push -fa
> *edit the file where hunks from the patch did not apply such that the patch
> is applied "by hand"*
> quilt refresh
> quilt pop -fa
> bzr commit

patching file plugins/decor/decor.xml.in
Hunk #4 FAILED at 101.
1 out of 4 hunks FAILED -- saving rejects to file plugins/decor/decor.xml.in.rej

<default>/usr/bin/gtk-window-decorator</default>
vs.
<default>exec \"${COMPIZ_BIN_PATH}compiz-decorator\"</default>
vs.
<default>exec ${COMPIZ_BIN_PATH}/compiz-decorator</default>
and
exec "${COMPIZ_BIN_PATH}/compiz-decorator"
Question:
Is COMPIZ_BIN_PATH set up automatically for this, or does the user have to set it up?
`ccsm` program->'Effects' section->'Window Decoration' plugin->'General' tab->'Command' option->...

Even though this can't put quote around the path (so the path could have a space), it's still better than <default>exec \"${COMPIZ_BIN_PATH}compiz-decorator\"</default>

« Back to merge proposal