Code review comment for lp:~bryanfritt/compiz/compiz-decorator_script-edit_1192376

Revision history for this message
MC Return (mc-return) wrote :

> > So, for example:
> >
> > 1 indent: 4 spaces
> > 2 indents: 1 tab
> > 3 indents: 1 tab, 4 spaces
> > 4 indents: 2 tabs
> > 5 indents: 2 tabs, 4 spaces
> >
> > etc
>
> Even with a Bash script too? If you try to drag and drop a line of code onto a
> Bash terminal window, everywhere there's a tab it'll try to do a tab
> completion(`ls` or whatever it's called). Which looks weird, even though it
> doesn't affect how the code runs. Spaces instead of tabs would be good for
> those who want to test parts of the script out this way.
>
I agree that the C++ X11 indentation style is not needed and would look weird in bash scripts.

> > camelCase
> In Bash environment variables, and global variables, are conventionally done
> in all UPPERCASE
> http://stackoverflow.com/questions/673055/correct-bash-and-shell-script-
> variable-capitalization
>
I agree here also.

> > Please re-target to lp:compiz
>
> What does this mean? / How to?

1. Copy your commit message (as you will need it again).
2. Open your branch: lp:~bryanfritt/compiz/compiz-decorator_script-edit_1192376
3. Propose a new merge into lp:compiz, which is Compiz 0.9.11-dev now (this here is now lp:compiz/0.9.10).
4. Paste your commit message again, when you're done.

« Back to merge proposal