Code review comment for lp:~bryanfritt/compiz/compiz-decorator_script-edit_1192376

Revision history for this message
Sam Spilsbury (smspillaz) wrote :

> The one I should have submitted should have been done after 3751 `chmod +x`,
> the last thing I've done with this code. I hadn't thought of any changes to do
> with it since then, and it's working for me, so I guess I'm done with this set
> of edits, except for now messing with what you said, the using four spaces in
> place of a tab.
>
> "These changes are inconsistent with the coding style. Use 8-wide tabs for two
> indents and 4-spaces for one indent, or, if the language doesn't support it,
> use 4-spaces for indents."
> I didn't know about the coding style. Where can I read it?
> Should be an easy change. No problem. It'll actually be easier to do copy
> paste code type testing on to the shell with spaces instead of tab. (tab
> characters cause 'tab completions' to activate during copy paste, which makes
> things look weird...)
>

Oops - I was going to mention. This is on wiki.compiz.org, but that's down again. I'll grab the link as soon as it comes back up. Basically:

 1. 8-wide tab for two indents, 4 spaces for the last indent for odd indent levels
 2. Space in-between () and identifiers
 3. camelCase
 4. Braces fall on the same line as the start of the control condition, eg:

    if (1)
    {
    }

« Back to merge proposal