Code review comment for lp:~bryanfritt/compiz/compiz-decorator_script-edit_1192376

Revision history for this message
MC Return (mc-return) wrote :

>
> I've edited/started/done a start-compiz and a start-ccsm script, they export
> LD_LIBRARY_PATH, and PYTHONPATH, etc...

You seem to be the script master ;)
Great -> useful scripts are very welcome. +1 for engaging this.

> How can I get them into Compiz?
> They would be new files that aren't in there currently, so I have to find and
> mess with an install script and add them in somehow?
> (and/or perhaps Compiz could be made so that these scripts would be optional)
>

You can add directories and files with "bzr add filename".
We already have a scripts/ directory in the Compiz source, so simply add your script(s) with "bzr add scripts/scriptname.sh" to get them under version control, then "bzr commit" and "bzr push", like you've already learned ;)

> Guess I start a new branch/bug report?
>

Yes, please. Unrelated issues should not be mixed. Also it helps review to have everything separated.
Please also take care of typos and try to commit best-quality stuff only, make no compromises there ;)
I guess GPL v2 licensing of your code is okay for you ?

« Back to merge proposal