Code review comment for lp:~bryanfritt/compiz/compiz-decorator_script-edit_1192376
Revision history for this message
| MC Return (mc-return) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
7020100
(Get the code!)
MP == Merge Proposal
Search "Work in progress" on this page via browser if you cannot find it ;)
Well, there is no hard rule regarding the commit message, but:
I always start uppercase and end with punctuation, but your commit message is okay that way as well...
It would be good to add "(LP: #1192376)" at the bottom to have the link to the bug directly in the commit message.
I hope Sam can take a look at this also soon, as I am no expert regarding this script, but generally this looks good already and I cannot find anything that is obviously wrong.