Code review comment for lp:~brunonova/software-properties/lp1381050

Revision history for this message
Bruno Nova (brunonova) wrote :

I just checked the KDE version to see if it works.
When I add or remove a key, an error is displayed, but it seems that the key is actually added/removed.
software-properties-kde must be run as root, and doesn't seem to use DBus.

I investigated a bit.
These actions call the KeysModified() method. This method raises an exception in the KDE version... because it doesn't exist in this version! And it seems that the only thing that the method does is log a debug message.
I'll probably report a new bug for this issue.

Also, from the tests I made, the changes in this branch and in the other (drag&drop bug) should not break the KDE version.

« Back to merge proposal