Code review comment for lp:~broder/ubuntu-dev-tools/fix-785854

Revision history for this message
Stefano Rivera (stefanor) wrote :

Looks reasonable, although running inspect is a bit icky.

Do we not need some copyright attribution on code copied verbatim from Python?

As I understand the close_fds issue, closing them is sensible on Linux but possibly not on Windows. We can afford to not care about that case.

ubuntutools/test/example_package.py hasn't been changed to import this version.

« Back to merge proposal