Code review comment for lp:~broder/ubuntu-dev-tools/backportpackage

Revision history for this message
Stefano Rivera (stefanor) wrote :

Sorry yes, I was commenting from memory, always a bad idea. The only check based on "ppa:" is to add ~ppa1. That's fine.

New issue: Your use subprocess.call and check_call. You use it correctly for pull-lp-source.
For dch, you should probably check "== 0", instead of "not" because returncode can be negative if dch was killed.
For debuild, remember that check_call will throw, not return, on error.

review: Needs Fixing

« Back to merge proposal