Merge lp:~brightbox/vmbuilder/exclude-first-cylinder into lp:vmbuilder
Proposed by
Neil Wilson
Status: | Needs review | ||||
---|---|---|---|---|---|
Proposed branch: | lp:~brightbox/vmbuilder/exclude-first-cylinder | ||||
Merge into: | lp:vmbuilder | ||||
Diff against target: |
43 lines (+8/-3) 3 files modified
VMBuilder/contrib/cli.py (+1/-1) VMBuilder/disk.py (+6/-1) VMBuilder/plugins/ubuntu/dapper.py (+1/-1) |
||||
To merge this branch: | bzr merge lp:~brightbox/vmbuilder/exclude-first-cylinder | ||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
VMBuilder | Pending | ||
Review via email: mp+42530@code.launchpad.net |
Description of the change
There are three changes in this branch.
- Reserve 63 sectors at the beginning of a disk for partition table details. This ensure that grub doesn't use blocklists and allows the user to switch to GPT if they so desire.
- A fix for the manifest option.
- A fix so that the file list format works with disks.
The commits can be cherry picked as required.
HTH.
To post a comment you must log in.
Unmerged revisions
- 460. By Neil Wilson <email address hidden>
-
Merge upstream
- 459. By Neil Wilson <email address hidden>
-
Fix to exclude first cylinder (sectors 0-62) from partition for the
benefit of grub. - 458. By Neil Wilson <email address hidden>
-
Merge lp:vmbuilder
- 457. By Neil Wilson <email address hidden>
-
Remove the split limit so that file partition layouts can be used on disks
- 456. By Neil Wilson <email address hidden>
-
Fix failing manifest option.
Hi Neil,
are there bugs open for the other two commits? I'll go ahead and cherry-pick
the one relevant to 578199 right now, but would like tosee testcases for hte
other two. (i.e. the .split(' ') one - what would be in pair[2:], and do we
actually always want to discard it?)