Merge lp:~brightbox/ubuntu/raring/lvm2/fix-for-1075994 into lp:ubuntu/raring/lvm2

Proposed by Neil Wilson
Status: Merged
Merged at revision: 75
Proposed branch: lp:~brightbox/ubuntu/raring/lvm2/fix-for-1075994
Merge into: lp:ubuntu/raring/lvm2
Diff against target: 78 lines (+52/-0) (has conflicts)
3 files modified
debian/changelog (+12/-0)
debian/patches/1075994_move_thin_check_executable_to_proper_section.patch (+39/-0)
debian/patches/series (+1/-0)
Text conflict in debian/changelog
To merge this branch: bzr merge lp:~brightbox/ubuntu/raring/lvm2/fix-for-1075994
Reviewer Review Type Date Requested Status
Ubuntu branches Pending
Review via email: mp+142531@code.launchpad.net

Description of the change

Now that the Xmas time-sink is out of the way I've retargeted this patch to the raring branch of lvm2 following the process at http://developer.ubuntu.com/packaging/html/fixing-a-bug.html

The patch has the correct DEP3 headers in now.

To post a comment you must log in.
Revision history for this message
Dimitri John Ledkov (xnox) wrote :

The patch does not have the correct DEP3 headers, as they should not start with "##".
Let me review your thin-provisioning packaging first, before merging this.

75. By Neil Wilson

Remove unnecessary ## from patch header

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'debian/changelog'
--- debian/changelog 2013-01-09 15:31:14 +0000
+++ debian/changelog 2013-01-10 19:36:20 +0000
@@ -1,9 +1,21 @@
1<<<<<<< TREE
1lvm2 (2.02.95-5ubuntu2) UNRELEASED; urgency=low2lvm2 (2.02.95-5ubuntu2) UNRELEASED; urgency=low
23
3 * Use upstream dmeventd.8 manpage (LP: #1076304) 4 * Use upstream dmeventd.8 manpage (LP: #1076304)
45
5 -- Neil Wilson <neil@aldur.co.uk> Wed, 09 Jan 2013 15:28:11 +00006 -- Neil Wilson <neil@aldur.co.uk> Wed, 09 Jan 2013 15:28:11 +0000
67
8=======
9lvm2 (2.02.95-5ubuntu2) UNRELEASED; urgency=low
10
11 * debian/patches/1075994_move_thin_check_executable_to_proper_section.
12 patch:
13 - put thin_check_executable in the 'global' section
14 - look for thin_check in /usr/sbin (LP: #1075994)
15
16 -- Neil Wilson <neil@aldur.co.uk> Wed, 09 Jan 2013 14:36:04 +0000
17
18>>>>>>> MERGE-SOURCE
7lvm2 (2.02.95-5ubuntu1) raring; urgency=low19lvm2 (2.02.95-5ubuntu1) raring; urgency=low
820
9 * Merge from Debian unstable, remaining changes (LP: #1082325):21 * Merge from Debian unstable, remaining changes (LP: #1082325):
1022
=== added file 'debian/patches/1075994_move_thin_check_executable_to_proper_section.patch'
--- debian/patches/1075994_move_thin_check_executable_to_proper_section.patch 1970-01-01 00:00:00 +0000
+++ debian/patches/1075994_move_thin_check_executable_to_proper_section.patch 2013-01-10 19:36:20 +0000
@@ -0,0 +1,39 @@
1Description: Move thin_check_executable to proper section
2Origin: upstream, http://git.fedorahosted.org/cgit/lvm2.git/commit/?id=8db4540263f607e2113a405953000527ffd34b3c
3Bug-Ubuntu: https://launchpad.net/bugs/1075994
4--- a/doc/example.conf.in
5+++ b/doc/example.conf.in
6@@ -463,6 +463,16 @@
7 # proper udev rules, all changes in block device configuration will be
8 # *ignored* until a manual 'vgscan' is performed.
9 use_lvmetad = 0
10+
11+ # Full path of the utility called to check that a thin metadata device
12+ # is in a state that allows it to be used.
13+ # Each time a thin pool needs to be activated, this utility is executed.
14+ # The activation will only proceed if the utility has an exit status of 0.
15+ # Set to "" to skip this check. (Not recommended.)
16+ # The thin tools are available as part of the device-mapper-persistent-data
17+ # package from https://github.com/jthornber/thin-provisioning-tools.
18+ #
19+ thin_check_executable = "/usr/sbin/thin_check -q"
20 }
21
22 activation {
23@@ -650,16 +660,6 @@
24 thin_pool_autoextend_threshold = 100
25 thin_pool_autoextend_percent = 20
26
27- # Full path of the utility called to check that a thin metadata device
28- # is in a state that allows it to be used.
29- # Each time a thin pool needs to be activated, this utility is executed.
30- # The activation will only proceed if the utility has an exit status of 0.
31- # Set to "" to skip this check. (Not recommended.)
32- # The thin tools are available as part of the device-mapper-persistent-data
33- # package from https://github.com/jthornber/thin-provisioning-tools.
34- #
35- thin_check_executable = "/sbin/thin_check -q"
36-
37 # While activating devices, I/O to devices being (re)configured is
38 # suspended, and as a precaution against deadlocks, LVM2 needs to pin
39 # any memory it is using so it is not paged out. Groups of pages that
040
=== modified file 'debian/patches/series'
--- debian/patches/series 2012-11-26 10:35:00 +0000
+++ debian/patches/series 2013-01-10 19:36:20 +0000
@@ -11,3 +11,4 @@
11upstream-fix-discard-2.patch11upstream-fix-discard-2.patch
12upstream-fix-discard-3.patch12upstream-fix-discard-3.patch
13missing-dmeventd.patch13missing-dmeventd.patch
141075994_move_thin_check_executable_to_proper_section.patch

Subscribers

People subscribed via source and target branches

to all changes: