Merge lp:~brightbox/ubuntu/raring/lvm2/fix-for-1075994 into lp:ubuntu/raring/lvm2

Proposed by Neil Wilson
Status: Merged
Merged at revision: 75
Proposed branch: lp:~brightbox/ubuntu/raring/lvm2/fix-for-1075994
Merge into: lp:ubuntu/raring/lvm2
Diff against target: 78 lines (+52/-0) (has conflicts)
3 files modified
debian/changelog (+12/-0)
debian/patches/1075994_move_thin_check_executable_to_proper_section.patch (+39/-0)
debian/patches/series (+1/-0)
Text conflict in debian/changelog
To merge this branch: bzr merge lp:~brightbox/ubuntu/raring/lvm2/fix-for-1075994
Reviewer Review Type Date Requested Status
Ubuntu branches Pending
Review via email: mp+142531@code.launchpad.net

Description of the change

Now that the Xmas time-sink is out of the way I've retargeted this patch to the raring branch of lvm2 following the process at http://developer.ubuntu.com/packaging/html/fixing-a-bug.html

The patch has the correct DEP3 headers in now.

To post a comment you must log in.
Revision history for this message
Dimitri John Ledkov (xnox) wrote :

The patch does not have the correct DEP3 headers, as they should not start with "##".
Let me review your thin-provisioning packaging first, before merging this.

75. By Neil Wilson

Remove unnecessary ## from patch header

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'debian/changelog'
2--- debian/changelog 2013-01-09 15:31:14 +0000
3+++ debian/changelog 2013-01-10 19:36:20 +0000
4@@ -1,9 +1,21 @@
5+<<<<<<< TREE
6 lvm2 (2.02.95-5ubuntu2) UNRELEASED; urgency=low
7
8 * Use upstream dmeventd.8 manpage (LP: #1076304)
9
10 -- Neil Wilson <neil@aldur.co.uk> Wed, 09 Jan 2013 15:28:11 +0000
11
12+=======
13+lvm2 (2.02.95-5ubuntu2) UNRELEASED; urgency=low
14+
15+ * debian/patches/1075994_move_thin_check_executable_to_proper_section.
16+ patch:
17+ - put thin_check_executable in the 'global' section
18+ - look for thin_check in /usr/sbin (LP: #1075994)
19+
20+ -- Neil Wilson <neil@aldur.co.uk> Wed, 09 Jan 2013 14:36:04 +0000
21+
22+>>>>>>> MERGE-SOURCE
23 lvm2 (2.02.95-5ubuntu1) raring; urgency=low
24
25 * Merge from Debian unstable, remaining changes (LP: #1082325):
26
27=== added file 'debian/patches/1075994_move_thin_check_executable_to_proper_section.patch'
28--- debian/patches/1075994_move_thin_check_executable_to_proper_section.patch 1970-01-01 00:00:00 +0000
29+++ debian/patches/1075994_move_thin_check_executable_to_proper_section.patch 2013-01-10 19:36:20 +0000
30@@ -0,0 +1,39 @@
31+Description: Move thin_check_executable to proper section
32+Origin: upstream, http://git.fedorahosted.org/cgit/lvm2.git/commit/?id=8db4540263f607e2113a405953000527ffd34b3c
33+Bug-Ubuntu: https://launchpad.net/bugs/1075994
34+--- a/doc/example.conf.in
35++++ b/doc/example.conf.in
36+@@ -463,6 +463,16 @@
37+ # proper udev rules, all changes in block device configuration will be
38+ # *ignored* until a manual 'vgscan' is performed.
39+ use_lvmetad = 0
40++
41++ # Full path of the utility called to check that a thin metadata device
42++ # is in a state that allows it to be used.
43++ # Each time a thin pool needs to be activated, this utility is executed.
44++ # The activation will only proceed if the utility has an exit status of 0.
45++ # Set to "" to skip this check. (Not recommended.)
46++ # The thin tools are available as part of the device-mapper-persistent-data
47++ # package from https://github.com/jthornber/thin-provisioning-tools.
48++ #
49++ thin_check_executable = "/usr/sbin/thin_check -q"
50+ }
51+
52+ activation {
53+@@ -650,16 +660,6 @@
54+ thin_pool_autoextend_threshold = 100
55+ thin_pool_autoextend_percent = 20
56+
57+- # Full path of the utility called to check that a thin metadata device
58+- # is in a state that allows it to be used.
59+- # Each time a thin pool needs to be activated, this utility is executed.
60+- # The activation will only proceed if the utility has an exit status of 0.
61+- # Set to "" to skip this check. (Not recommended.)
62+- # The thin tools are available as part of the device-mapper-persistent-data
63+- # package from https://github.com/jthornber/thin-provisioning-tools.
64+- #
65+- thin_check_executable = "/sbin/thin_check -q"
66+-
67+ # While activating devices, I/O to devices being (re)configured is
68+ # suspended, and as a precaution against deadlocks, LVM2 needs to pin
69+ # any memory it is using so it is not paged out. Groups of pages that
70
71=== modified file 'debian/patches/series'
72--- debian/patches/series 2012-11-26 10:35:00 +0000
73+++ debian/patches/series 2013-01-10 19:36:20 +0000
74@@ -11,3 +11,4 @@
75 upstream-fix-discard-2.patch
76 upstream-fix-discard-3.patch
77 missing-dmeventd.patch
78+1075994_move_thin_check_executable_to_proper_section.patch

Subscribers

People subscribed via source and target branches

to all changes: