Code review comment for lp:~brian.curtin/ubuntuone-dev-tools/py3-getPage-replacement

Revision history for this message
Alejandro J. Cura (alecu) wrote :

When running the sso tests with this branch I get a lot of errors similar to this:

test_ssl_fail_dialog_user_accepts_via_proxy ... Traceback (most recent call last):
  File "/usr/lib/python2.7/dist-packages/twisted/internet/defer.py", line 1039, in _inlineCallbacks
    result = g.send(result)
  File "/home/alecu/canonical/ubuntu-sso-client/trunk/ubuntu_sso/utils/webclient/tests/test_webclient.py", line 969, in setUp
    self.ws = HTTPSMockWebServer(self.ssl_settings)
  File "/home/alecu/canonical/ubuntu-sso-client/trunk/ubuntu_sso/utils/webclient/tests/test_webclient.py", line 239, in __init__
    super(HTTPSMockWebServer, self).__init__(root, ssl_settings)
exceptions.TypeError: must be type, not classobj

review: Needs Fixing

« Back to merge proposal