Branch looks good!
Two minor nitpicks:
* Any reason to have this:
from ubuntuone.syncdaemon import config, event_queue, tritcask from ubuntuone.syncdaemon import volume_manager
instead of:
from ubuntuone.syncdaemon import config, event_queue, tritcask, volume_manager
?
* Can you please add the docstring for this method?
def validate_path_for_folder(self, path):
* Shouldn't we call normpath(path) before checking if the path is inside the user home?
Tests are green in both OSes, yey! (except for bug #929546 which is not relevant to this branch) Thanks!
« Back to merge proposal
Branch looks good!
Two minor nitpicks:
* Any reason to have this:
from ubuntuone. syncdaemon import config, event_queue, tritcask syncdaemon import volume_manager
from ubuntuone.
instead of:
from ubuntuone. syncdaemon import config, event_queue, tritcask, volume_manager
?
* Can you please add the docstring for this method?
def validate_ path_for_ folder( self, path):
* Shouldn't we call normpath(path) before checking if the path is inside the user home?
Tests are green in both OSes, yey! (except for bug #929546 which is not relevant to this branch)
Thanks!