On Fri, 2012-11-02 at 19:49 +0000, Brian Curtin wrote:
> 1. I'm fine with moving the files to ubuntuone-client-data. If that's
> acceptable, I'll go ahead and do it.
There are some packaging concerns here, so needs a bit of coordination
to do. And given 2.) below, I need to think about this a little bit
more, I suppose.
> 2. I don't like duplicating the code either, but I've had my "release
> Windows ASAP" hat on. Given the dependency situation that we want to
> step around, where can I feasibly put get_cert_location? dirspec,
> devtools?
The API call and the cert files should be in the same project I think,
but this does also mean we need to think a bit more about where to put
those files and API exactly.
> 3. As for breakage on Linux without storage-protocol or those specific
> certs - it shouldn't affect it. If nothing turns up when we go to look
> for our specific certs, they just won't be configured.
> test_setup_no_certs checks this by faking out the search for
> "UbuntuOne*.crt" with an empty list and ensures that WebClient can
> still start up.
Great.
> 4. Perhaps I've been focused too much on the stop-gap approach, but
> I'm all for doing this properly the first time. I don't really like
> this MP as-is, but could use this type of response to get it into
> shape.
It will require a bit more thought and work, so I think for now, the
best solution for getting a new Windows release out, is to use this
(though I would change the duplicated code to just import the call from
ubuntuone.storageprotocol.context to reduce the size of the patch, and
any potential for issues due to the code duplication.
On Fri, 2012-11-02 at 19:49 +0000, Brian Curtin wrote: client- data. If that's
> 1. I'm fine with moving the files to ubuntuone-
> acceptable, I'll go ahead and do it.
There are some packaging concerns here, so needs a bit of coordination
to do. And given 2.) below, I need to think about this a little bit
more, I suppose.
> 2. I don't like duplicating the code either, but I've had my "release
> Windows ASAP" hat on. Given the dependency situation that we want to
> step around, where can I feasibly put get_cert_location? dirspec,
> devtools?
The API call and the cert files should be in the same project I think,
but this does also mean we need to think a bit more about where to put
those files and API exactly.
> 3. As for breakage on Linux without storage-protocol or those specific
> certs - it shouldn't affect it. If nothing turns up when we go to look
> for our specific certs, they just won't be configured.
> test_setup_no_certs checks this by faking out the search for
> "UbuntuOne*.crt" with an empty list and ensures that WebClient can
> still start up.
Great.
> 4. Perhaps I've been focused too much on the stop-gap approach, but
> I'm all for doing this properly the first time. I don't really like
> this MP as-is, but could use this type of response to get it into
> shape.
It will require a bit more thought and work, so I think for now, the storageprotocol .context to reduce the size of the patch, and
best solution for getting a new Windows release out, is to use this
(though I would change the duplicated code to just import the call from
ubuntuone.
any potential for issues due to the code duplication.