Code review comment for lp:~brian.curtin/ubuntu-sso-client/local-certs

Revision history for this message
Brian Curtin (brian.curtin) wrote :

1. I'm fine with moving the files to ubuntuone-client-data. If that's acceptable, I'll go ahead and do it.
2. I don't like duplicating the code either, but I've had my "release Windows ASAP" hat on. Given the dependency situation that we want to step around, where can I feasibly put get_cert_location? dirspec, devtools?
3. As for breakage on Linux without storage-protocol or those specific certs - it shouldn't affect it. If nothing turns up when we go to look for our specific certs, they just won't be configured. test_setup_no_certs checks this by faking out the search for "UbuntuOne*.crt" with an empty list and ensures that WebClient can still start up.
4. Perhaps I've been focused too much on the stop-gap approach, but I'm all for doing this properly the first time. I don't really like this MP as-is, but could use this type of response to get it into shape.

« Back to merge proposal