Merge lp:~brian-murray/ubuntu-release-upgrader/bug-1225016 into lp:ubuntu-release-upgrader

Proposed by Brian Murray
Status: Merged
Merge reported by: Steve Langasek
Merged at revision: not available
Proposed branch: lp:~brian-murray/ubuntu-release-upgrader/bug-1225016
Merge into: lp:ubuntu-release-upgrader
Diff against target: 51 lines (+8/-6)
3 files modified
DistUpgrade/DistUpgradeCache.py (+5/-5)
data/DistUpgrade.cfg (+1/-1)
data/removal_blacklist.cfg (+2/-0)
To merge this branch: bzr merge lp:~brian-murray/ubuntu-release-upgrader/bug-1225016
Reviewer Review Type Date Requested Status
Steve Langasek Pending
Review via email: mp+185671@code.launchpad.net

Description of the change

I've modified the release upgrader to ensure that the metapackage information is in sync, but thought it could use a second pair of eyes.

To post a comment you must log in.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'DistUpgrade/DistUpgradeCache.py'
--- DistUpgrade/DistUpgradeCache.py 2013-09-12 16:16:49 +0000
+++ DistUpgrade/DistUpgradeCache.py 2013-09-15 14:29:21 +0000
@@ -866,16 +866,16 @@
866 break866 break
867 # check if we actually found one867 # check if we actually found one
868 if not metaPkgInstalled():868 if not metaPkgInstalled():
869 # FIXME: provide a list869 meta_pkgs = ', '.join(metapkgs[0:-1])
870 view.error(_("Can't guess meta-package"),870 view.error(_("Can't guess meta-package"),
871 _("Your system does not contain a "871 _("Your system does not contain a "
872 "ubuntu-desktop, kubuntu-desktop, xubuntu-desktop or "872 "%s or %s package and it was not "
873 "edubuntu-desktop package and it was not "
874 "possible to detect which version of "873 "possible to detect which version of "
875 "Ubuntu you are running.\n "874 "Ubuntu you are running.\n "
876 "Please install one of the packages "875 "Please install one of the packages "
877 "above first using synaptic or "876 "above first using synaptic or "
878 "apt-get before proceeding."))877 "apt-get before proceeding.") %
878 (meta_pkgs, metapkgs[-1]))
879 return False879 return False
880 return True880 return True
881881
882882
=== modified file 'data/DistUpgrade.cfg'
--- data/DistUpgrade.cfg 2013-04-30 18:17:22 +0000
+++ data/DistUpgrade.cfg 2013-09-15 14:29:21 +0000
@@ -10,7 +10,7 @@
10# Distro contains global information about the upgrade10# Distro contains global information about the upgrade
11[Distro]11[Distro]
12# the meta-pkgs we support12# the meta-pkgs we support
13MetaPkgs=ubuntu-desktop, kubuntu-desktop, xubuntu-desktop, ubuntustudio-desktop, ichthux-desktop, mythbuntu-desktop, ubuntu-netbook, kubuntu-netbook, lubuntu-desktop13MetaPkgs=ubuntu-desktop, kubuntu-desktop, xubuntu-desktop, ubuntustudio-desktop, mythbuntu-desktop, kubuntu-netbook, lubuntu-desktop
14BaseMetaPkgs=ubuntu-minimal, ubuntu-standard14BaseMetaPkgs=ubuntu-minimal, ubuntu-standard
15Demotions=demoted.cfg15Demotions=demoted.cfg
16RemoveEssentialOk=sysvinit, sysvutils, belocs-locales-bin16RemoveEssentialOk=sysvinit, sysvutils, belocs-locales-bin
1717
=== modified file 'data/removal_blacklist.cfg'
--- data/removal_blacklist.cfg 2012-09-04 08:01:44 +0000
+++ data/removal_blacklist.cfg 2013-09-15 14:29:21 +0000
@@ -5,6 +5,8 @@
5kubuntu-desktop5kubuntu-desktop
6xubuntu-desktop6xubuntu-desktop
7lubuntu-desktop7lubuntu-desktop
8mythbuntu-desktop
9ubuntustudio-desktop
8# ubuntu-release-upgrader should not remove itself or update-manager10# ubuntu-release-upgrader should not remove itself or update-manager
9update-manager11update-manager
10update-manager-core12update-manager-core

Subscribers

People subscribed via source and target branches