Merge lp:~brian-murray/ubuntu-archive-tools/phasing-progress-link into lp:ubuntu-archive-tools

Proposed by Brian Murray
Status: Merged
Merged at revision: 940
Proposed branch: lp:~brian-murray/ubuntu-archive-tools/phasing-progress-link
Merge into: lp:ubuntu-archive-tools
Diff against target: 40 lines (+8/-4)
1 file modified
phased-updater (+8/-4)
To merge this branch: bzr merge lp:~brian-murray/ubuntu-archive-tools/phasing-progress-link
Reviewer Review Type Date Requested Status
Steve Langasek Needs Fixing
Review via email: mp+251517@code.launchpad.net

Description of the change

I thought it'd be helpful to make uploaders more aware of the phasing report by including it in the email to them.

To post a comment you must log in.
Revision history for this message
Steve Langasek (vorlon) wrote :

minor suggested change inline.

review: Needs Fixing
941. By Brian Murray

phased-updater: add and extra \n

Revision history for this message
Brian Murray (brian-murray) wrote :

Okay, fixed.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'phased-updater'
--- phased-updater 2015-02-27 16:11:38 +0000
+++ phased-updater 2015-03-02 22:20:22 +0000
@@ -193,8 +193,8 @@
193 report.write('''</body>\n''')193 report.write('''</body>\n''')
194 report.write('''</html>''')194 report.write('''</html>''')
195 report.flush()195 report.flush()
196 shutil.copy2(report.name, '%s/phased-updates.html' % os.getcwd())196 shutil.copy2(report.name, '%s/%s' % (os.getcwd(), REPORT_FILE))
197 os.chmod('%s/phased-updates.html' % os.getcwd(), 0o644)197 os.chmod('%s/%s' % (os.getcwd(), REPORT_FILE), 0o644)
198198
199199
200def create_email_notifications(releases, spph_buckets):200def create_email_notifications(releases, spph_buckets):
@@ -223,12 +223,15 @@
223 'to the previous two weeks. For problems currently being '223 'to the previous two weeks. For problems currently being '
224 'reported about the package see:\n\n'224 'reported about the package see:\n\n'
225 '%s\n\n')225 '%s\n\n')
226 remedy = ('Further phasing of this update has been stopped until the '226 remedy = ('You can view the current status of the phasing of all '
227 'Stable Release Updates, including yours, at:\n\n'
228 'http://people.canonical.com/~ubuntu-archive/%s\n\n'
229 'Further phasing of this update has been stopped until the '
227 'errors have either been fixed or determined to not be a '230 'errors have either been fixed or determined to not be a '
228 'result of this Stable Release Update. In the event of '231 'result of this Stable Release Update. In the event of '
229 'the latter please let a member of the Ubuntu Stable Release '232 'the latter please let a member of the Ubuntu Stable Release '
230 'Updates team (~ubuntu-sru) know so that phasing of the update '233 'Updates team (~ubuntu-sru) know so that phasing of the update '
231 'can proceed.')234 'can proceed.' % (REPORT_FILE))
232 for release in releases:235 for release in releases:
233 rname = release.name236 rname = release.name
234 for spph in spph_buckets[rname]:237 for spph in spph_buckets[rname]:
@@ -618,6 +621,7 @@
618 NOTIFICATIONS = 'phased-updates-emails.txt'621 NOTIFICATIONS = 'phased-updates-emails.txt'
619 EMAIL_SENDER = 'brian.murray@ubuntu.com'622 EMAIL_SENDER = 'brian.murray@ubuntu.com'
620 PUP_INCREMENT = 10623 PUP_INCREMENT = 10
624 REPORT_FILE = 'phased-updates.html'
621 parser = OptionParser(usage="usage: %prog [options]")625 parser = OptionParser(usage="usage: %prog [options]")
622 parser.add_option(626 parser.add_option(
623 "-l", "--launchpad", dest="launchpad_instance", default="production")627 "-l", "--launchpad", dest="launchpad_instance", default="production")

Subscribers

People subscribed via source and target branches