Merge lp:~brian-murray/ubuntu-archive-tools/phasing-progress-link into lp:ubuntu-archive-tools

Proposed by Brian Murray
Status: Merged
Merged at revision: 940
Proposed branch: lp:~brian-murray/ubuntu-archive-tools/phasing-progress-link
Merge into: lp:ubuntu-archive-tools
Diff against target: 40 lines (+8/-4)
1 file modified
phased-updater (+8/-4)
To merge this branch: bzr merge lp:~brian-murray/ubuntu-archive-tools/phasing-progress-link
Reviewer Review Type Date Requested Status
Steve Langasek Needs Fixing
Review via email: mp+251517@code.launchpad.net

Description of the change

I thought it'd be helpful to make uploaders more aware of the phasing report by including it in the email to them.

To post a comment you must log in.
Revision history for this message
Steve Langasek (vorlon) wrote :

minor suggested change inline.

review: Needs Fixing
941. By Brian Murray

phased-updater: add and extra \n

Revision history for this message
Brian Murray (brian-murray) wrote :

Okay, fixed.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'phased-updater'
2--- phased-updater 2015-02-27 16:11:38 +0000
3+++ phased-updater 2015-03-02 22:20:22 +0000
4@@ -193,8 +193,8 @@
5 report.write('''</body>\n''')
6 report.write('''</html>''')
7 report.flush()
8- shutil.copy2(report.name, '%s/phased-updates.html' % os.getcwd())
9- os.chmod('%s/phased-updates.html' % os.getcwd(), 0o644)
10+ shutil.copy2(report.name, '%s/%s' % (os.getcwd(), REPORT_FILE))
11+ os.chmod('%s/%s' % (os.getcwd(), REPORT_FILE), 0o644)
12
13
14 def create_email_notifications(releases, spph_buckets):
15@@ -223,12 +223,15 @@
16 'to the previous two weeks. For problems currently being '
17 'reported about the package see:\n\n'
18 '%s\n\n')
19- remedy = ('Further phasing of this update has been stopped until the '
20+ remedy = ('You can view the current status of the phasing of all '
21+ 'Stable Release Updates, including yours, at:\n\n'
22+ 'http://people.canonical.com/~ubuntu-archive/%s\n\n'
23+ 'Further phasing of this update has been stopped until the '
24 'errors have either been fixed or determined to not be a '
25 'result of this Stable Release Update. In the event of '
26 'the latter please let a member of the Ubuntu Stable Release '
27 'Updates team (~ubuntu-sru) know so that phasing of the update '
28- 'can proceed.')
29+ 'can proceed.' % (REPORT_FILE))
30 for release in releases:
31 rname = release.name
32 for spph in spph_buckets[rname]:
33@@ -618,6 +621,7 @@
34 NOTIFICATIONS = 'phased-updates-emails.txt'
35 EMAIL_SENDER = 'brian.murray@ubuntu.com'
36 PUP_INCREMENT = 10
37+ REPORT_FILE = 'phased-updates.html'
38 parser = OptionParser(usage="usage: %prog [options]")
39 parser.add_option(
40 "-l", "--launchpad", dest="launchpad_instance", default="production")

Subscribers

People subscribed via source and target branches