Code review comment for lp:~brian-murray/ubuntu-archive-tools/override-rate

Revision history for this message
Colin Watson (cjwatson) wrote :

18:10 <cjwatson> what happens if the package isn't built on i386 at all?
18:11 <cjwatson> maybe my proof of concept was a bit naive - you could search without distro_arch_series= and then go through the results looking for things where .distro_arch_series.distro_series (or however it's spelled) is release
18:11 <cjwatson> I'm also concerned that this appears to go through the entire history
18:12 <cjwatson> you should get it back in ordered form, so I think you would be better off stopping at the most recent publication that matches your criteria
18:12 <cjwatson> (i.e. you should get it most recent first IIRC)
18:13 <bdmurray> right and most recent is zero, so just use [1]?
18:15 <cjwatson> I'd use a for loop and break once you've found a publication you like

review: Needs Fixing

« Back to merge proposal