Merge lp:~brian-murray/launchpad/display-dupe-in-portlet-dupe-subscribers into lp:launchpad
Status: | Merged |
---|---|
Approved by: | Brian Murray |
Approved revision: | no longer in the source branch. |
Merged at revision: | 11531 |
Proposed branch: | lp:~brian-murray/launchpad/display-dupe-in-portlet-dupe-subscribers |
Merge into: | lp:launchpad |
Diff against target: |
146 lines (+46/-11) 5 files modified
lib/lp/bugs/doc/bugsubscription.txt (+4/-4) lib/lp/bugs/interfaces/bugsubscription.py (+4/-0) lib/lp/bugs/model/bugsubscription.py (+10/-1) lib/lp/bugs/stories/bugs/xx-bug-personal-subscriptions.txt (+4/-4) lib/lp/bugs/templates/bug-portlet-dupe-subscribers-content.pt (+24/-2) |
To merge this branch: | bzr merge lp:~brian-murray/launchpad/display-dupe-in-portlet-dupe-subscribers |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Abel Deuring (community) | code | Approve | |
Robert Collins (community) | Needs Fixing | ||
Matthew Revell | text | Pending | |
Review via email: mp+34501@code.launchpad.net |
Commit message
Display the number of the duplicate bug to which a subscriber is subscribed in the subscriptions from duplicates portlet.
Description of the change
When a bug has a lot of duplicates and subscribers from duplicates it would be useful to know which duplicate you were subscribed to without checking every single duplicate bug to find out.
Instead you can mouse over your name in the subscription and find out to which one you are subscribed.
Test modified:
bin/test -cvvt bugsubscription.txt xx-bug-
I'd be happy to continue using the macro"bug/
Two small points: have you checked the query impact of this? It looks
like it will do a lot of queries, to me.
Separately, have you considered just having the list of 'can
unsubscribe' things include separate actions for each bug.
e.g.
subscribers
teamfoo [-]
teamfoo (via 1234) [-]
teambar (via 3456) [-]
This would keep the unsubscribe actions in the same place (a good
thing), not make showing the list of dupes more expensive ( a good
thing) and leave the dup list cacheable if we choose to) (a good
thing)