Merge lp:~brian-murray/launchpad/bug-912137 into lp:launchpad
Proposed by
Brian Murray
Status: | Merged | ||||
---|---|---|---|---|---|
Approved by: | j.c.sackett | ||||
Approved revision: | no longer in the source branch. | ||||
Merged at revision: | 15385 | ||||
Proposed branch: | lp:~brian-murray/launchpad/bug-912137 | ||||
Merge into: | lp:launchpad | ||||
Diff against target: |
112 lines (+19/-12) 2 files modified
lib/lp/app/javascript/subscribers/subscribers_list.js (+13/-6) lib/lp/app/javascript/subscribers/tests/test_subscribers_list.js (+6/-6) |
||||
To merge this branch: | bzr merge lp:~brian-murray/launchpad/bug-912137 | ||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
j.c.sackett (community) | Approve | ||
Review via email: mp+109045@code.launchpad.net |
Commit message
Fixes sort ordering of subscribers in the subscriber portlet
Description of the change
Summary
If you look at a bug like bug 764701 you'll notice the subscribers are sorted in a reverse order of what you would expect. This makes it a bit harder to determine whether or not a specific team or person is subscribed to any bug report. This was reported in bug 912137.
Proposed fix
Instead of inserting subscribers at the start of the list, in subscribers_
Tests
bin/test -vv -t test_subscriber
Demo and Q/A
I also tested this using the sample data and viewing bug #9 which has two subscribers and confirmed that they were in a normal order.
To post a comment you must log in.
Brian--
Thanks for this--it's good, it just needs one fix.
As we discussed on IRC, this has the side effect of new subscribers added via the UI being added to the bottom of the list. Because subscriber lists can quite long, new ones should be added to the top so the user can see that they were in fact added.
You could update addSubscriber to accept a parameter that indicates whether it's adding subscribers from a list of existing ones--which should be appended, or is adding a brand new subscriber which should be prepended. If you default this argument to indicate appending, then you should just need to update the call site that is bound to the `Subscribe someone else` button.