Code review comment for lp:~brian-murray/launchpad/bug-320596

Revision history for this message
Abel Deuring (adeuring) wrote :

Hi Brian,

nice work! Just one minor nitpicks: I find the name "modifiable_params" and "modified_params" a bit confusing. What about "params_for_api_1_0" and "params_for_devel"? And since these variables are defined on mudole level, perhaps even "searchtasks_params_for_api_1_0"? (Having modified_params and modifiable_params for a second exported method might lead to funny results ;)

review: Approve (code)

« Back to merge proposal