Code review comment for lp:~brian-murray/launchpad/bug-320596

Revision history for this message
Robert Collins (lifeless) wrote :

So, I have some needs fixing and a question.

needs fixing: please don't add these things to doctests: none of your tests look like documentation, so they shouldn't be expressed as documentation.

question: looks like you're breaking the 1.0 API to me, I thought that wasn't permitted.

review: Needs Fixing

« Back to merge proposal