Merge lp:~brian-murray/laika/add-merge-proposals into lp:laika

Proposed by Brian Murray
Status: Merged
Merged at revision: 21
Proposed branch: lp:~brian-murray/laika/add-merge-proposals
Merge into: lp:laika
Diff against target: 34 lines (+12/-0)
1 file modified
laika (+12/-0)
To merge this branch: bzr merge lp:~brian-murray/laika/add-merge-proposals
Reviewer Review Type Date Requested Status
Alex Chiang Approve
Review via email: mp+123383@code.launchpad.net

Description of the change

I thought it would be neat to see the merge proposals that were created by the user. This branch implements that.

I also added a print statement in reported bugs in case the user did not report any bugs.

To post a comment you must log in.
Revision history for this message
Alex Chiang (achiang) wrote :

Looks good. I tested it and it found my merge proposals.

Thanks for the patch!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'laika'
--- laika 2012-04-02 16:33:21 +0000
+++ laika 2012-09-07 23:19:19 +0000
@@ -187,6 +187,7 @@
187 if self.in_window(t.bug.date_created):187 if self.in_window(t.bug.date_created):
188 self.print_bugid(t)188 self.print_bugid(t)
189 print189 print
190 print
190191
191 def print_ppa_activity(self):192 def print_ppa_activity(self):
192 if self.ppas == '':193 if self.ppas == '':
@@ -222,11 +223,22 @@
222 print223 print
223 print224 print
224225
226 def print_merge_proposals(self):
227 mps = self.user.getMergeProposals()
228 if len(mps) == 0:
229 return
230 self.print_header("Merge Proposals")
231 for mp in mps:
232 if self.in_window(mp.date_created):
233 print "%s - %s" % (mp.target_branch.display_name, mp.web_link)
234 print
235
225 def render(self):236 def render(self):
226 self.print_assignments()237 self.print_assignments()
227 self.print_comments()238 self.print_comments()
228 self.print_reported()239 self.print_reported()
229 self.print_ppa_activity()240 self.print_ppa_activity()
241 self.print_merge_proposals()
230242
231def get_config(opts):243def get_config(opts):
232 config = {}244 config = {}

Subscribers

People subscribed via source and target branches