Merge lp:~brian-murray/errors/user-packages into lp:errors

[Brian Murray]

This sets the filter for 'packages subscribed to by' to the logged in user if there is one. I've also added an event for package_selection on enter so that one can switch back to no filter by choosing 'all binary packages' and pressing enter.

I wanted this reviewed and tested as request.user.username was always returning openiduser for me.

[Evan (ev)]

This looks good, save the superfluous space next to 'var loggedin_user'. It correctly sets the box to ~ev for me.

review: Approve

=== modified file 'errors/static/js/most_common_problems.js'
--- errors/static/js/most_common_problems.js	2013-03-12 14:53:12 +0000
+++ errors/static/js/most_common_problems.js	2013-03-20 03:37:22 +0000
@@ -1,7 +1,7 @@
 var current_from_value;
 var current_to_value;
 
-function most_common_problems_table() {
+function most_common_problems_table(loggedin_user) {
 YUI().use('node', 'io-queue', 'io-form', 'datatable', 'datatable-sort',
     'datasource-get', 'datasource-jsonschema', 'datatable-datasource',
     'datatable-message', 'datatype', 'event-key', 'event-valuechange',
@@ -336,10 +336,13 @@
                     Y.one('#package_name').setStyle('display', 'none');
                     return;
                 } else {
+                    Y.one('#package').set('value', '');
+                    Y.one('#user').set('value', '');
                     Y.one('#package_name').setStyle('visibility', 'hidden');
                     Y.one('#package_name').setStyle('display', 'none');
                     Y.one('#subscriber_name').setStyle('visibility', 'hidden');
                     Y.one('#subscriber_name').setStyle('display', 'none');
+                    return;
                 }
             }
         });
@@ -389,6 +392,7 @@
         }
     }
 
+    Y.one('#package_selection').on('key', interval_changed, 'enter');
     Y.one('#package').on('key', package_changed, 'enter');
     Y.one('#package').on('blur', package_changed, 'enter');
     Y.one('#user').on('key', interval_changed, 'enter');
@@ -428,6 +432,9 @@
             Y.one('#package').set('value', query_string.package);
             package_changed(false, expected_version);
         }
+        if (loggedin_user !== '') {
+            query_string.user = loggedin_user;
+        }
         if (query_string.user !== undefined) {
             update = true;
             Y.one('#package_selection').get("options").each(function() {

=== modified file 'errors/templates/main.html'
--- errors/templates/main.html	2013-03-12 17:58:43 +0000
+++ errors/templates/main.html	2013-03-20 03:37:22 +0000
@@ -19,12 +19,14 @@
 <script type="text/javascript" src="/static/js/most_common_problems.js"></script>
 
 <script type="text/javascript">
-    {% if user.is_authenticated %}
+    {% if request.user.is_authenticated %}
     /* This is just a guide to the view. Do not /ever/ use this as an
      * authentication check. */
     var user_is_authenticated = true;
+    var loggedin_user =  '{{ request.user.username }}';
     {% else %}
     var user_is_authenticated = false;
+    var loggedin_user = '';
     {% endif %}
 
     var means = {
@@ -44,7 +46,7 @@
                 Y.one('#notes').setStyle('display', 'block');
             }
             mean_time_between_failures_graph(means);
-            most_common_problems_table();
+            most_common_problems_table(loggedin_user);
         });
     });
 </script>