Merge lp:~brian-murray/errors/bug-to-crash-sig into lp:errors

[Brian Murray]

This is based on Evan's initial work for this and provides an API way to find crash signatures associated with a bug report.

[Evan (ev)]

get_signatures_for_bug should return an empty list on failure, otherwise the code in resources.py will try to do a slice on None.

Otherwise this looks good. Feel free to merge it in with that change.

review: Approve

[lp:~brian-murray/errors/bug-to-crash-sig]

380. By Brian Murray on 2013-03-28

return an empty list if no crash signatures are found

=== modified file 'errors/api/resources.py'
--- errors/api/resources.py	2013-03-12 19:18:22 +0000
+++ errors/api/resources.py	2013-03-28 16:20:27 +0000
@@ -558,3 +558,17 @@
                                     'derivatives': -1,
                                     'total': total_total})
         return wrapped()
+
+
+class CrashSignaturesForBug(ErrorsResource):
+    signatures = fields.ListField(attribute='signatures', readonly=True)
+
+    class Meta(ErrorsMeta):
+        resource_name = 'crash-signatures-for-bug'
+    def obj_get_list(self, request):
+        bug = request.GET.get('bug', None)
+        class wrapped(list):
+            def __getslice__(self, start, finish):
+                results = cassandra.get_signatures_for_bug(bug)
+                return results[start:finish]
+        return wrapped()

=== modified file 'errors/api/urls.py'
--- errors/api/urls.py	2013-03-08 21:52:59 +0000
+++ errors/api/urls.py	2013-03-28 16:20:27 +0000
@@ -15,7 +15,8 @@
                         AverageInstancesResource,
                         InstancesResource,
                         VersionsResource,
-                        PackageVersionIsMostRecent)
+                        PackageVersionIsMostRecent,
+                        CrashSignaturesForBug)
 
 v1_api = Api(api_name='1.0')
 v1_api.register(RetraceResultResource())
@@ -34,6 +35,7 @@
 v1_api.register(AverageInstancesResource())
 v1_api.register(InstancesResource())
 v1_api.register(VersionsResource())
+v1_api.register(CrashSignaturesForBug())
 
 urlpatterns = patterns('',
     url(r'^', include(v1_api.urls)),

=== modified file 'errors/cassandra.py'
--- errors/cassandra.py	2013-03-27 22:04:22 +0000
+++ errors/cassandra.py	2013-03-28 16:20:27 +0000
@@ -469,7 +469,17 @@
 
 def record_bug_for_bucket(bucketid, bug):
     bucketmetadata_cf = pycassa.ColumnFamily(pool, 'BucketMetadata')
+    bugtocrashsignatures_cf = pycassa.ColumnFamily(pool, 'BugToCrashSignatures')
     # We don't insert bugs into the database if we're using Launchpad staging,
     # as those will disappear in Launchpad but our copy would persist.
     if not config.lp_use_staging:
         bucketmetadata_cf.insert(bucketid, {'CreatedBug' : bug})
+        bugtocrashsignatures_cf.insert(bug, {bucketid: ''})
+
+def get_signatures_for_bug(bug):
+    bugtocrashsignatures_cf = pycassa.ColumnFamily(pool, 'BugToCrashSignatures')
+    try:
+        crashes = [crash for crash in bugtocrashsignatures_cf.xget(bug)]
+        return crashes
+    except NotFoundException:
+        return []