Code review comment for lp:~brian-murray/daisy/remove-sandbox-dir-after-retrace

Could we not teach retracer.py to just use apport's --cache and not
--sandbox-dir? It seems like a bug that --sandbox-dir is an optional
argument in retracer.py despite it very much not being an optional
thing. :)

Either way you want to implement it, though.

On 21 March 2014 13:33, Brian Murray <email address hidden> wrote:
> I think removing --sandbox-dir does more than we actually want. I'm suggesting that we stop using apport-retrace's "--sandbox-dir" option but continuing to use "--cache".
>
> "--sandbox-dir" for retracer.py is a combination of both of these as setup_cache returns the directory for "--sandbox-dir" for apport-retrace and the directory for "--cache". So by not using retracer.py's --sandbox-dir we'll lose the benefit of cacheing deb files.
> --
> https://code.launchpad.net/~brian-murray/daisy/remove-sandbox-dir-after-retrace/+merge/212187
> You are reviewing the proposed merge of lp:~brian-murray/daisy/remove-sandbox-dir-after-retrace into lp:daisy.