Code review comment for lp:~brian-murray/cupstream2distro/bug-1460861

Revision history for this message
Robert Bruce Park (robru) wrote :

Look at your diff in the test suite. There are two changes happening:

1) you made the desired change of 'Author 1, Author 2' in the author names.

2) You changed a perfectly good dictionary into this bizarre list of tuples and it's significantly more difficult to read. so please change this:

+ commits = self.branch.get_branch_commits(set())
+ commits = sorted(commits.items())
+ self.assertEquals(commits, ([
+ ('Andrea Azzarone', [
+ 'Disable detail view for webapp icons. (LP: #1169340)'

Back to this:

- self.assertEquals(self.branch.get_branch_commits(set()), ({
- 'Sebastien Bacher': [
- "Use '%s:' string for preview hints, rather than just "
- "appending ':'. (LP: #1074038)"

The diff will guide you. Just eliminate all the changes that aren't string changes.

« Back to merge proposal