Code review comment for lp:~brian-murray/click/chroots

On Mon, Oct 07, 2013 at 09:00:45PM -0000, Brian Murray wrote:
> On Fri, Oct 04, 2013 at 08:45:46AM -0000, Colin Watson wrote:
> > I realise this is translated from mk-sbuild, but I'd prefer not to add
> > things described as group names to source-root-users; even if they
> > happen to coincide now it's a bit of a trap for the future.
> >
> > For this application, I would suggest that we want the calling user to
> > have full access, and also the root user for good measure (it could also
>
> This seems to have been cut off.

I'm not sure what I meant to say there. I don't think it was very
important.

> > > + def run(self, *args):
> > > + if not self.exists():
> > > + raise ClickChrootException(
> > > + "Chroot %s does not exist" % self.full_name)
> > > + command = ["schroot", "-c", self.full_name, "--directory=/", "--"]
> >
> > Why the --directory=/ here? I'm concerned that that will make it
> > difficult to do simple "run make in this directory"-type things, which
> > is a primary goal of this system.
> >
> > Perhaps this was a consequence of profile=sbuild, since not having your
> > home directory mounted would be a bit of a problem. If so, try dropping
> > this argument after dropping that profile.
>
> This is still an issue with my setup because of my encrypted home
> directory. Do you have any suggestions on how we may deal with users
> that also have one?

Maybe you need to bind-mount $HOME rather than /home?