Code review comment for lp:~brian-murray/apport/use-more-contents.gz

Revision history for this message
Martin Pitt (pitti) wrote :

Thanks! That's a good idea indeed. I'd like to make some changes to it, though:

 - Add a test case (backend_apt_dpkg.test_get_file_package_uninstalled)
 - The "not_found" logic is a bit hard to read, and unnecessary
 - This assumes that these additional pockets always exist, which isn't the case for e. g. Debian. So this would cause an URLError crash.

« Back to merge proposal