Code review comment for lp:~brian-murray/apport/use-launchpad

Still two inline comments which are simple to fix.

I now get three test failures from "test/run backend_apt_dpkg":

======================================================================
ERROR: test_install_old_packages (__main__.T)
sandbox will install older package versions from launchpad
----------------------------------------------------------------------
Traceback (most recent call last):
  File "backends/packaging-apt-dpkg.py", line 939, in install_packages
    cache.fetch_archives(fetcher=fetcher)
  File "/usr/lib/python3/dist-packages/apt/cache.py", line 352, in fetch_archives
    apt_pkg.PackageManager(self._depcache))
  File "/usr/lib/python3/dist-packages/apt/cache.py", line 327, in _fetch_archives
    return self._run_fetcher(fetcher)
  File "/usr/lib/python3/dist-packages/apt/cache.py", line 306, in _run_fetcher
    raise FetchFailedException(err_msg)
apt.cache.FetchFailedException: Failed to fetch https://launchpad.net/ubuntu/+archive/primary/+files/oxideqt-codecs_1.7.8-0ubuntu0.14.04.1_amd64.deb Received HTTP code 403 from proxy after CONNECT
Failed to fetch https://launchpad.net/ubuntu/+archive/primary/+files/oxideqt-codecs-dbg_1.7.8-0ubuntu0.14.04.1_amd64.deb Received HTTP code 403 from proxy after CONNECT

======================================================================
ERROR: test_install_packages_from_launchpad (__main__.T)
install_packages() using packages only available on Launchpad
----------------------------------------------------------------------
Traceback (most recent call last):
  File "backends/packaging-apt-dpkg.py", line 939, in install_packages
    cache.fetch_archives(fetcher=fetcher)
  File "/usr/lib/python3/dist-packages/apt/cache.py", line 352, in fetch_archives
    apt_pkg.PackageManager(self._depcache))
  File "/usr/lib/python3/dist-packages/apt/cache.py", line 327, in _fetch_archives
    return self._run_fetcher(fetcher)
  File "/usr/lib/python3/dist-packages/apt/cache.py", line 306, in _run_fetcher
    raise FetchFailedException(err_msg)
apt.cache.FetchFailedException: Failed to fetch https://launchpad.net/ubuntu/+archive/primary/+files/oxideqt-codecs_1.6.6-0ubuntu0.14.04.1_amd64.deb Received HTTP code 403 from proxy after CONNECT
Failed to fetch https://launchpad.net/ubuntu/+archive/primary/+files/oxideqt-codecs-dbg_1.6.6-0ubuntu0.14.04.1_amd64.deb Received HTTP code 403 from proxy after CONNECT
Failed to fetch https://launchpad.net/ubuntu/+archive/primary/+files/distro-info-data_0.18ubuntu0.2_all.deb Received HTTP code 403 from proxy after CONNECT
Failed to fetch https://launchpad.net/ubuntu/+archive/primary/+files/qemu-utils_2.0.0+dfsg-2ubuntu1.11_amd64.deb Received HTTP code 403 from proxy after CONNECT
Failed to fetch https://launchpad.net/ubuntu/+archive/primary/+files/qemu-utils-dbgsym_2.0.0+dfsg-2ubuntu1.11_amd64.ddeb Received HTTP code 403 from proxy after CONNECT

test_get_source_tree_lp_sandbox (__main__.T) ... W: GPG error: http://ddebs.ubuntu.com trusty Release: The following signatures couldn't be verified because the public key is not available: NO_PUBKEY ECDCAD72428D7C01
E: Can not find version '20101020ubuntu318.16' of package 'debian-installer'
E: Unable to find a source package for debian-installer
FAIL

======================================================================
FAIL: test_get_source_tree_lp_sandbox (__main__.T)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "test/test_backend_apt_dpkg.py", line 977, in test_get_source_tree_lp_sandbox
    sandbox=self.rootdir, apt_update=True)
  File "backends/packaging-apt-dpkg.py", line 574, in get_source_tree
    assert root, 'could not determine source tree root directory'
AssertionError: could not determine source tree root directory

Do you get these as well? I tried that with and without the Canonical VPN, same result.

I also get these when I run tests individually, like "test/run backend_apt_dpkg.test_install_old_packages". So it's not cruft from other tests either.

Thanks!