Merge lp:~brian-murray/apport/bug-1316841 into lp:~apport-hackers/apport/trunk

Proposed by Brian Murray
Status: Merged
Merged at revision: 2800
Proposed branch: lp:~brian-murray/apport/bug-1316841
Merge into: lp:~apport-hackers/apport/trunk
Diff against target: 35 lines (+6/-1)
2 files modified
NEWS (+2/-0)
data/apportcheckresume (+4/-1)
To merge this branch: bzr merge lp:~brian-murray/apport/bug-1316841
Reviewer Review Type Date Requested Status
Martin Pitt (community) Approve
Review via email: mp+219038@code.launchpad.net

Description of the change

suspend resume failures have no duplicate signature so aren't bucketed in the error tracker. This fixes that by using report.crash_signature().

To post a comment you must log in.
lp:~brian-murray/apport/bug-1316841 updated
2801. By Brian Murray

add some more whitespace

Revision history for this message
Martin Pitt (pitti) wrote :

Thanks!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'NEWS'
--- NEWS 2014-05-06 05:59:20 +0000
+++ NEWS 2014-05-09 20:12:06 +0000
@@ -5,6 +5,8 @@
5-------------------5-------------------
6 * Add kernel package version to the various kernel-related hooks. Thanks Brian6 * Add kernel package version to the various kernel-related hooks. Thanks Brian
7 Murray.7 Murray.
8 * Add a duplicate signature to suspend resume failures. Thanks Brian Murray.
9 (LP: #1316841)
810
92.14.2 (2014-04-30)112.14.2 (2014-04-30)
10-------------------12-------------------
1113
=== modified file 'data/apportcheckresume'
--- data/apportcheckresume 2014-04-29 17:41:29 +0000
+++ data/apportcheckresume 2014-05-09 20:12:06 +0000
@@ -10,7 +10,6 @@
10# the full text of the license.10# the full text of the license.
1111
12import os12import os
13import os.path
14import sys13import sys
15import datetime14import datetime
1615
@@ -84,6 +83,10 @@
84 if pr.check_ignored():83 if pr.check_ignored():
85 return 084 return 0
8685
86 crash_signature = pr.crash_signature()
87 if crash_signature:
88 pr['DuplicateSignature'] = crash_signature
89
87 nowtime = datetime.datetime.now()90 nowtime = datetime.datetime.now()
88 pr_filename = '/var/crash/susres.%s.crash' % (str(nowtime).replace(' ', '_'))91 pr_filename = '/var/crash/susres.%s.crash' % (str(nowtime).replace(' ', '_'))
89 with os.fdopen(os.open(pr_filename, os.O_WRONLY | os.O_CREAT | os.O_EXCL, 0o640), 'wb') as report_file:92 with os.fdopen(os.open(pr_filename, os.O_WRONLY | os.O_CREAT | os.O_EXCL, 0o640), 'wb') as report_file:

Subscribers

People subscribed via source and target branches