Merge lp:~brian-murray/apport/bug-1316841 into lp:~apport-hackers/apport/trunk

Proposed by Brian Murray
Status: Merged
Merged at revision: 2800
Proposed branch: lp:~brian-murray/apport/bug-1316841
Merge into: lp:~apport-hackers/apport/trunk
Diff against target: 35 lines (+6/-1)
2 files modified
NEWS (+2/-0)
data/apportcheckresume (+4/-1)
To merge this branch: bzr merge lp:~brian-murray/apport/bug-1316841
Reviewer Review Type Date Requested Status
Martin Pitt (community) Approve
Review via email: mp+219038@code.launchpad.net

Description of the change

suspend resume failures have no duplicate signature so aren't bucketed in the error tracker. This fixes that by using report.crash_signature().

To post a comment you must log in.
lp:~brian-murray/apport/bug-1316841 updated
2801. By Brian Murray

add some more whitespace

Revision history for this message
Martin Pitt (pitti) wrote :

Thanks!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'NEWS'
2--- NEWS 2014-05-06 05:59:20 +0000
3+++ NEWS 2014-05-09 20:12:06 +0000
4@@ -5,6 +5,8 @@
5 -------------------
6 * Add kernel package version to the various kernel-related hooks. Thanks Brian
7 Murray.
8+ * Add a duplicate signature to suspend resume failures. Thanks Brian Murray.
9+ (LP: #1316841)
10
11 2.14.2 (2014-04-30)
12 -------------------
13
14=== modified file 'data/apportcheckresume'
15--- data/apportcheckresume 2014-04-29 17:41:29 +0000
16+++ data/apportcheckresume 2014-05-09 20:12:06 +0000
17@@ -10,7 +10,6 @@
18 # the full text of the license.
19
20 import os
21-import os.path
22 import sys
23 import datetime
24
25@@ -84,6 +83,10 @@
26 if pr.check_ignored():
27 return 0
28
29+ crash_signature = pr.crash_signature()
30+ if crash_signature:
31+ pr['DuplicateSignature'] = crash_signature
32+
33 nowtime = datetime.datetime.now()
34 pr_filename = '/var/crash/susres.%s.crash' % (str(nowtime).replace(' ', '_'))
35 with os.fdopen(os.open(pr_filename, os.O_WRONLY | os.O_CREAT | os.O_EXCL, 0o640), 'wb') as report_file:

Subscribers

People subscribed via source and target branches