Merge lp:~brendan-donegan/qakit/get_instances_pagination into lp:qakit

[Brendan Donegan]

Get all instances, handle instances with no external ID and add subunit as a dependency

Fix a couple of issues I hit whilst trying to upload results to a testset in PractiTest:

1.) get_instances was using _get and not _get_all so only ever got the first 250 instances, meaning some test results weren't uploaded
2.) get_test was being passed None when an instance had no external ID - this needed to be handled
3.) python-subunit was missing from the setup.py so couldn't run from the virtualenv

[Allan LeSage (allanlesage)]

OK LGTM, merging.

review: Approve

=== modified file 'qakit/practitest/practitest.py'
--- qakit/practitest/practitest.py	2015-06-30 14:44:59 +0000
+++ qakit/practitest/practitest.py	2015-08-19 18:26:49 +0000
@@ -184,7 +184,7 @@
 
         """
         url = PROD_PRACTITEST + '/sets/{}/instances.json'.format(id)
-        return self._get(url).json()['data']
+        return self._get_all(url)
 
     def create_instances(self, set_id, test_ids):
         """
@@ -283,9 +283,10 @@
 
         """
         test_id = self._get_id_of_test_by_name(instance['name'], tests)
-        # TODO: handle None
-        test = self.get_test(test_id)
-        return self.get_test_custom_field(test, custom_field_name)
+        if test_id is not None:
+            test = self.get_test(test_id)
+            return self.get_test_custom_field(test, custom_field_name)
+        return None
 
     def get_issues(self, id):
         """Return issues given a filter id
 
=== modified file 'setup.py'
--- setup.py	2015-06-23 14:57:17 +0000
+++ setup.py	2015-08-19 18:26:49 +0000
@@ -35,6 +35,7 @@
         # 'bleach',
         # 'prettytable',
         'python-dateutil',
+        'python-subunit',
         'requests',
         # 'termcolor',
         # 'trello',