Merge lp:~brendan-donegan/qakit/get_instances_pagination into lp:qakit
Proposed by
Brendan Donegan
Status: | Merged |
---|---|
Approved by: | Allan LeSage |
Approved revision: | 12 |
Merged at revision: | 12 |
Proposed branch: | lp:~brendan-donegan/qakit/get_instances_pagination |
Merge into: | lp:qakit |
Diff against target: |
38 lines (+6/-4) 2 files modified
qakit/practitest/practitest.py (+5/-4) setup.py (+1/-0) |
To merge this branch: | bzr merge lp:~brendan-donegan/qakit/get_instances_pagination |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Allan LeSage (community) | Approve | ||
Review via email: mp+268529@code.launchpad.net |
Commit message
Get all instances, handle instances with no external ID and add subunit as a dependency
Description of the change
Fix a couple of issues I hit whilst trying to upload results to a testset in PractiTest:
1.) get_instances was using _get and not _get_all so only ever got the first 250 instances, meaning some test results weren't uploaded
2.) get_test was being passed None when an instance had no external ID - this needed to be handled
3.) python-subunit was missing from the setup.py so couldn't run from the virtualenv
To post a comment you must log in.
OK LGTM, merging.