Merge lp:~brendan-donegan/checkbox/improve_checkbox_gui_description into lp:~checkbox-dev/checkbox/checkbox-packaging

[Brendan Donegan]

Make sure Description of checkbox-gui package is kept nicely wrapped at 80 characters. This is enough to make Debian happy according to spineau.

[Zygmunt Krynicki (zyga)]

Could you fix it so that the first line is standalone. It is a common
practice for programs to display the first line of the description as a
"summary" line. Here it's being cut at "on the PlainBox test" which sounds
bad. Try to rewrite it to squeeze it into limits and be sensible on its own.

On Mon, Jan 27, 2014 at 2:48 PM, Brendan Donegan <
<email address hidden>> wrote:

> Brendan Donegan has proposed merging
> lp:~brendan-donegan/checkbox/improve_checkbox_gui_description into
> lp:~checkbox-dev/checkbox/checkbox-packaging.
>
> Requested reviews:
> Checkbox Developers (checkbox-dev)
>
> For more details, see:
>
> https://code.launchpad.net/~brendan-donegan/checkbox/improve_checkbox_gui_description/+merge/203323
>
> Make sure Description of checkbox-gui package is kept nicely wrapped at 80
> characters. This is enough to make Debian happy according to spineau.
>
> --
>
> https://code.launchpad.net/~brendan-donegan/checkbox/improve_checkbox_gui_description/+merge/203323
> Your team Checkbox Developers is requested to review the proposed merge of
> lp:~brendan-donegan/checkbox/improve_checkbox_gui_description into
> lp:~checkbox-dev/checkbox/checkbox-packaging.
>
> === modified file 'debian/control'
> --- debian/control 2014-01-07 14:03:28 +0000
> +++ debian/control 2014-01-27 13:47:52 +0000
> @@ -437,7 +437,8 @@
> Provides: checkbox-qt
> Conflicts: checkbox-qt
> Replaces: checkbox-qt
> -Description: QML based interface for system testing based on the PlainBox
> test framework
> - Provides an interface for executing system tests. The results can be
> viewed at the end.
> +Description: QML based interface for system testing based on the PlainBox
> test
> + framework. Provides an interface for executing system tests. The
> + results can be viewed at the end.
> .
> This package provides the checkbox-gui binary.
>
>
>

[Sylvain Pineau (sylvain-pineau)]

like this:

Description: QML based interface for system testing based on PlainBox
 Provides an interface for executing system tests. The results can be viewed
 at the end.
 .
 This package provides the checkbox-gui binary.

[Zygmunt Krynicki (zyga)]

Yeah, I like Sylvain's suggestion. Can we make it happen?

review: Needs Fixing

[lp:~brendan-donegan/checkbox/improve_checkbox_gui_description]

56. By Brendan Donegan on 2014-01-28

Better first line

[Brendan Donegan (brendan-donegan)]

Sorry, I wasn't aware of that. Updated.

review: Needs Resubmitting

[Sylvain Pineau (sylvain-pineau)]

perfect, thanks

review: Approve

=== modified file 'debian/control'
--- debian/control	2014-01-27 19:18:29 +0000
+++ debian/control	2014-01-28 10:53:43 +0000
@@ -438,7 +438,8 @@
 Provides: checkbox-qt
 Conflicts: checkbox-qt
 Replaces: checkbox-qt
-Description: QML based interface for system testing based on the PlainBox test framework
- Provides an interface for executing system tests. The results can be viewed at the end.
+Description: QML based interface for system testing based on Plainbox.
+ Provides an interface for executing system tests. The results can be 
+ viewed at the end.
  .
  This package provides the checkbox-gui binary.