Merge lp:~brendan-donegan/checkbox/bug926417_cli_plus_help into lp:checkbox

Proposed by Brendan Donegan
Status: Merged
Merged at revision: 1233
Proposed branch: lp:~brendan-donegan/checkbox/bug926417_cli_plus_help
Merge into: lp:checkbox
Diff against target: 27 lines (+5/-2)
2 files modified
checkbox_cli/cli_interface.py (+1/-1)
debian/changelog (+4/-1)
To merge this branch: bzr merge lp:~brendan-donegan/checkbox/bug926417_cli_plus_help
Reviewer Review Type Date Requested Status
Marc Tardif (community) Approve
Review via email: mp+91819@code.launchpad.net

Description of the change

Change checkbox-cli text to be clearer about what the + key does.

To post a comment you must log in.
Revision history for this message
Marc Tardif (cr3) wrote :

Looks good, I also took the opportunity of putting your string in the gettext function so that it can be internationalized. Merging...

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'checkbox_cli/cli_interface.py'
--- checkbox_cli/cli_interface.py 2011-10-18 18:25:14 +0000
+++ checkbox_cli/cli_interface.py 2012-02-07 13:16:19 +0000
@@ -280,7 +280,7 @@
280 for option in keys:280 for option in keys:
281 dialog.add_option(option)281 dialog.add_option(option)
282282
283 dialog.add_option("Plus to expand options", "+")283 dialog.add_option("Combine with character above to expand node", "+")
284 dialog.add_option("Space when finished", " ")284 dialog.add_option("Space when finished", " ")
285285
286 do_expand = False286 do_expand = False
287287
=== modified file 'debian/changelog'
--- debian/changelog 2012-02-06 20:04:05 +0000
+++ debian/changelog 2012-02-07 13:16:19 +0000
@@ -12,7 +12,10 @@
12 [Daniel Manrique]12 [Daniel Manrique]
13 * Changed way of obtaining preferred browser to ensure we honor the user's13 * Changed way of obtaining preferred browser to ensure we honor the user's
14 preference rather than Chromium's clobbering of14 preference rather than Chromium's clobbering of
15 /etc/alternatives/gnome-www-browser (LP: #925603) 15 /etc/alternatives/gnome-www-browser (LP: #925603)
16
17 [Brendan Donegan]
18 * Changed checkbox-cli text to clearly explain what + does (LP: #926417)
1619
17 -- Daniel Manrique <daniel.manrique@canonical.com> Mon, 06 Feb 2012 14:55:58 -050020 -- Daniel Manrique <daniel.manrique@canonical.com> Mon, 06 Feb 2012 14:55:58 -0500
1821

Subscribers

People subscribed via source and target branches