Merge lp:~brendan-donegan/checkbox/bug1065932 into lp:checkbox

Proposed by Brendan Donegan
Status: Merged
Merged at revision: 1764
Proposed branch: lp:~brendan-donegan/checkbox/bug1065932
Merge into: lp:checkbox
Diff against target: 42 lines (+8/-4)
2 files modified
debian/changelog (+4/-0)
jobs/suspend.txt.in (+4/-4)
To merge this branch: bzr merge lp:~brendan-donegan/checkbox/bug1065932
Reviewer Review Type Date Requested Status
Jeff Marcom (community) Approve
Review via email: mp+129414@code.launchpad.net

Description of the change

This is just a tiny fix to make sure log files for FWTS suspend tests are correctly attached. Ensure that all log filenames end with .log so that FWTS doesn't mess with them.

To post a comment you must log in.
Revision history for this message
Jeff Marcom (jeffmarcom) wrote :

Looks good. Thanks

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'debian/changelog'
--- debian/changelog 2012-10-11 20:48:55 +0000
+++ debian/changelog 2012-10-12 12:45:18 +0000
@@ -7,6 +7,10 @@
7 jobs. Added a _description field to each so that the test cases properly7 jobs. Added a _description field to each so that the test cases properly
8 appear in the checkbox UI (LP: #1064189)8 appear in the checkbox UI (LP: #1064189)
99
10 [Brendan Donegan]
11 * jobs/suspend.txt.in - make sure FWTS logs end with .log so file names
12 don't get tampered with (LP: #1065932)
13
10 -- Daniel Manrique <roadmr@ubuntu.com> Wed, 10 Oct 2012 09:45:08 -040014 -- Daniel Manrique <roadmr@ubuntu.com> Wed, 10 Oct 2012 09:45:08 -0400
1115
12checkbox (0.14.6) quantal; urgency=low16checkbox (0.14.6) quantal; urgency=low
1317
=== modified file 'jobs/suspend.txt.in'
--- jobs/suspend.txt.in 2012-10-11 16:12:10 +0000
+++ jobs/suspend.txt.in 2012-10-12 12:45:18 +0000
@@ -99,8 +99,8 @@
99command:99command:
100 if type -P fwts >/dev/null; then100 if type -P fwts >/dev/null; then
101 echo "Calling fwts"101 echo "Calling fwts"
102 fwts s3 --s3-sleep-delay=30 -r $CHECKBOX_DATA/suspend_single_log102 fwts s3 --s3-sleep-delay=30 -r $CHECKBOX_DATA/suspend_single.log
103 grep 'Critical failures: NONE' $CHECKBOX_DATA/suspend_single_log103 grep 'Critical failures: NONE' $CHECKBOX_DATA/suspend_single.log
104 else104 else
105 echo "Calling sleep_test"105 echo "Calling sleep_test"
106 sleep_test -d106 sleep_test -d
@@ -125,11 +125,11 @@
125 This is the automated version of suspend/suspend_advanced.125 This is the automated version of suspend/suspend_advanced.
126user: root126user: root
127environ: CHECKBOX_DATA127environ: CHECKBOX_DATA
128command: fwts s3 --s3-sleep-delay=30 -r $CHECKBOX_DATA/suspend_single_log || true; grep 'Critical failures: NONE' $CHECKBOX_DATA/suspend_single_log.log128command: fwts s3 --s3-sleep-delay=30 -r $CHECKBOX_DATA/suspend_single.log || true; grep 'Critical failures: NONE' $CHECKBOX_DATA/suspend_single.log
129129
130plugin: attachment130plugin: attachment
131name: suspend/suspend-single-log-attach131name: suspend/suspend-single-log-attach
132command: [ -e $CHECKBOX_DATA/suspend_single_log ] && cat $CHECKBOX_DATA/suspend_single_log132command: [ -e $CHECKBOX_DATA/suspend_single.log ] && cat $CHECKBOX_DATA/suspend_single.log
133_description:133_description:
134 Attaches the log from the single suspend/resume test to the results134 Attaches the log from the single suspend/resume test to the results
135135

Subscribers

People subscribed via source and target branches