Merge lp:~brendan-donegan/checkbox/bug1032259_select_deselect_all_disable into lp:checkbox

[Brendan Donegan]

Very simple, disable the Select All and Deselect All buttons after 'Start Testing' is clicked. They no longer have any use then. Also had to tweak the onTestSelectionChanged function to make sure the buttons weren't re-enabled when clicking on the tree view after testing had started.

[Daniel Manrique (roadmr)]

Looks good, I tested it and works as advertised.

Merging, thanks!

review: Approve

=== modified file 'debian/changelog'
--- debian/changelog	2012-08-03 08:17:45 +0000
+++ debian/changelog	2012-08-03 11:27:48 +0000
@@ -12,6 +12,8 @@
     'Start Testing' has been clicked (LP: #1029815)
   * Put Component and Status into one tree view on the selection screen,
     rather than two seperate ones (LP: #1030871)
+  * Disable the Select All and Deselect All buttons in the selection
+    view during testing (LP: #1032259)
 
   [Daniel Manrique]
   * New version 0.14.3 for Quantal Quetzal development.
 
=== modified file 'qt/frontend/qtfront.cpp'
--- qt/frontend/qtfront.cpp	2012-08-02 15:12:33 +0000
+++ qt/frontend/qtfront.cpp	2012-08-03 11:27:48 +0000
@@ -130,9 +130,11 @@
     emit closedFrontend(m_doneTesting);
 }
 
-void QtFront::onTestSelectionChanged() {
-    ui->selectAllButton->setEnabled(! m_model->allInStatus(Qt::Checked));
-    ui->deselectAllButton->setEnabled(! m_model->allInStatus(Qt::Unchecked));
+void QtFront::onTestSelectionChanged(QModelIndex index) {
+    if (m_model->item(index.row())->isEnabled()) {
+        ui->selectAllButton->setEnabled(! m_model->allInStatus(Qt::Checked));
+        ui->deselectAllButton->setEnabled(! m_model->allInStatus(Qt::Unchecked));
+    }
 }
 
 void QtFront::onDeselectAllClicked() {
@@ -205,6 +207,8 @@
 
 void QtFront::onStartTestsClicked() {
     ui->buttonStartTesting->setEnabled(false);
+    ui->selectAllButton->setEnabled(false);
+    ui->deselectAllButton->setEnabled(false);
     m_model->setInteraction(false);
     emit startTestsClicked();
 }
 
=== modified file 'qt/frontend/qtfront.h'
--- qt/frontend/qtfront.h	2012-08-02 09:53:56 +0000
+++ qt/frontend/qtfront.h	2012-08-03 11:27:48 +0000
@@ -65,7 +65,7 @@
     void onFullTestsClicked();
     void onDeselectAllClicked();
     void onSelectAllClicked();
-    void onTestSelectionChanged();
+    void onTestSelectionChanged(QModelIndex index);
     void onStartTestsClicked();
     void onSubmitTestsClicked();
     void onNextTestClicked();